Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macos-system-configuration feature flag #2080

Closed
wants to merge 1 commit into from
Closed

Add macos-system-configuration feature flag #2080

wants to merge 1 commit into from

Conversation

littledivy
Copy link
Contributor

The system-configuration crate was added in #1955 to support macOS system proxy settings. However, it forces users to link to the SystemConfiguration framework.

This PR makes macOS system proxy a default feature in reqwest. Users can disable the feature and avoid the dyld startup cost of loading the framework.

@littledivy littledivy mentioned this pull request Jan 2, 2024
Open
@jsantell jsantell mentioned this pull request Jan 8, 2024
Closed
@tnull tnull mentioned this pull request Jan 26, 2024
Closed
@seanmonstar seanmonstar added the B-breaking-change Blocked: breaking change. label Jan 29, 2024
@littledivy littledivy force-pushed the macos-system-configuration-feature branch from 8bb1d65 to a52aa75 Compare February 1, 2024 05:53
@seanmonstar
Copy link
Owner

I'm curious, does v0.11.25 (which includes #2130) fix it so that this isn't needed?

If it's still needed, we can include this in the 0.12 release that is coming up soon. But wanted to check.

@tnull
Copy link
Contributor

tnull commented Mar 11, 2024 •
edited
Loading

I'm curious, does v0.11.25 (which includes #2130) fix it so that this isn't needed?

If it's still needed, we can include this in the 0.12 release that is coming up soon. But wanted to check.

@seanmonstar Yes, please include this fix. The inclusion of system-configuration let's our builds break left and right ever since reqwest shipped it. We now manually patch each release and probably will soon automate it. Moreover, since reqwest 0.11.25 shipped with #2130, MSRV is broken on macOS, see #2169.

Btw, given that MSRV keeps breaking, I'd highly suggest to re-add the Windows and macOS MSRV checks you had me drop in #1993.

@seanmonstar seanmonstar added this to the 0.12 milestone Mar 11, 2024
@seanmonstar seanmonstar mentioned this pull request Mar 18, 2024
Merged
@seanmonstar
Copy link
Owner

Merged this into 0.12-dev in #2185

@emilazy emilazy mentioned this pull request Sep 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
B-breaking-change Blocked: breaking change.
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
3 participants
@littledivy @seanmonstar @tnull